On Mon Dec 4 13:31:52 2023 +0000, Jacek Caban wrote:
The latest push had the same problem as previous ones: it lacked proper justification based on an analyze. Now that I filled that gap for you, we can move forward. !4574 is not a complete solution, more patches are still needed, please rebase and self re-review taking above into consideration. The patch removing outer_window could be split and misses a number of NULL checks.
I removed that patch for now, I'm looking what to do with it in the meantime and split it (I wish you'd say this from the beginning), but I don't think "avoiding invalid memory access" is lack of a proper justification though, even if the reason was different. I didn't add NULL checks because it didn't have them before, though, so I just wanted to keep same behavior and make it easier to review.
BTW sorry about the comment spam, those are old emails I sent long ago but the email bridge decided to post them now?!?