Re: [PATCH 0/6] MR679: vkd3d-shader: Refactor common code between vkd3d_shader_compile() and vkd3d_shader_scan().

[Henri Verbeet (＠hverbeet)]

> -            ERR("Unsupported source type %#x.\n", compile_info->source_type);
> -            ret = VKD3D_ERROR_INVALID_ARGUMENT;
> -            break;
> +            vkd3d_unreachable();

I imagine this is to make vkd3d_shader_scan() more similar to vkd3d_shader_compile(), but I think vkd3d_unreachable() is worse than the existing code.

I feel a bit ambivalent about this MR. It's nice to get rid of some duplication and room for potential inconsistencies between vkd3d_shader_scan() and vkd3d_shader_compile(), but I don't love scan_or_compile(), and its "compile" argument in particular.