Re: [PATCH v2 0/1] MR6791: msvcrt: Do not create in newer msvcrt versions a separate heap. (ASan)

[Piotr Caban (＠piotr)]

On Fri Nov  8 21:21:26 2024 +0000, Bernhard Übelacker wrote:
> No reason, except to have the four tests look kind of equal.
> Should I change these two tests to direct linking like this?
> diff --git a/dlls/msvcrt/tests/heap.c b/dlls/msvcrt/tests/heap.c
> index e6de728f2b7..e93f909be8d 100644
> --- a/dlls/msvcrt/tests/heap.c
> +++ b/dlls/msvcrt/tests/heap.c
> @@ -524,4 +524,11 @@ static void test_calloc(void)
>  }
>
> +void* __cdecl _get_heap_handle(void);
> +
> +static void test__get_heap_handle(void)
> +{
> +    ok(_get_heap_handle() != GetProcessHeap(), "Expected
> _get_heap_handle() not to return GetProcessHeap()\n");
> +}
> +
>  START_TEST(heap)
>  {
> @@ -530,3 +537,4 @@ START_TEST(heap)
>      test_malloc();
>      test_calloc();
> +    test__get_heap_handle();
>  }
> diff --git a/dlls/ucrtbase/tests/misc.c b/dlls/ucrtbase/tests/misc.c
> index ff1ed20f2f8..33fb326316a 100644
> --- a/dlls/ucrtbase/tests/misc.c
> +++ b/dlls/ucrtbase/tests/misc.c
> @@ -1707,4 +1707,11 @@ static void test_gmtime64(void)
>  }
>
> +void* __cdecl _get_heap_handle(void);
> +
> +static void test__get_heap_handle(void)
> +{
> +    ok(_get_heap_handle() == GetProcessHeap(), "Expected
> _get_heap_handle() to return GetProcessHeap()\n");
> +}
> +
>  START_TEST(misc)
>  {
> @@ -1753,3 +1760,4 @@ START_TEST(misc)
>  #endif
>      test_gmtime64();
> +    test__get_heap_handle();
>  }

Yes, please change the tests. Instead of defining function prototype in tests please add it to `malloc.h` header.