On Fri Nov 10 15:44:39 2023 +0000, Gabriel Ivăncescu wrote:
I see, I will look into them, thanks.
I'm still reviewing them, but I looked at get_cookie now, and I believe all the usages that use the document's `outer_window` currently should not be affected in any way.
Note that the doc's `outer_window` is permanently kept right now with no sort of reference other than at creation able to be NULL (for windowless documents created via `createHTMLDocument` for instance). After the patches, at least it becomes NULL when the outer window is killed instead of crashing/accessing invalid memory, so it actually has *less* impact.
That's why I'm reviewing only cases where we actually access it via `window->base.outer_window`, but let me know if I'm missing something…