Re: [PATCH 0/6] MR66: vkd3d-shader/hlsl: Broaden resources support v2 (PART 1).

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about libs/vkd3d-shader/hlsl.y:
> -
>    hlsl_fixme(ctx, loc, "Samples with gradients are not implemented.\n");
> -
>    return false;
> - }
> -
> - sampler_type = params->args[0]->data_type;
> - if (sampler_type->type != HLSL_CLASS_OBJECT || sampler_type->base_type != HLSL_TYPE_SAMPLER
> -
>        || (sampler_type->sampler_dim != dim && sampler_type->sampler_dim != HLSL_SAMPLER_DIM_GENERIC))
> - {
> -
>    struct vkd3d_string_buffer *string;
> -
> -
>    if ((string = hlsl_type_to_string(ctx, sampler_type)))
> -
>        hlsl_error(ctx, loc, VKD3D_SHADER_ERROR_HLSL_INVALID_TYPE,
> -
>                "Wrong type for argument 1 of '%s': expected 'sampler' or '%s', but got '%s'.",
> -
>                name, ctx->builtin_types.sampler[dim]->name, string->buffer);
> -
>    hlsl_release_string_buffer(ctx, string);
> -
>    return false;

We don't need to abort here.