On Tue Nov 21 19:15:05 2023 +0000, Zebediah Figura wrote:
I doubt it's a bug per se; PCM audio output doesn't need to be framed according to the corresponding input, and GStreamer is within its rights to split samples as it wishes. Rather, I suspect we should set the flag if and only if there are more samples to process. That might mean setting WG_SAMPLE_FLAG_INCOMPLETE in such a case for raw audio specifically, or it might mean adding a separate flag (WG_SAMPLE_FLAG_MORE_SAMPLES_AVAILABLE or something) and setting it for the WMA decoder specifically.
Hard to know if there are more samples to process, other than by simply always saying there's more and occasionally returning "sorry, I've got nothing after all". The first input packet returns zero output packets, so the DMO wrapper has to be prepared for unexpected emptiness anyways; might as well reuse that codepath.
This code is in the WMA decoder specifically.