Re: [PATCH 0/4] MR198: vkd3d-shader: Add more TPF validations.

[Henri Verbeet (＠hverbeet)]

> diff --git a/libs/vkd3d-shader/ir.c b/libs/vkd3d-shader/ir.c
> index 11ba7563..d0dc2978 100644
> --- a/libs/vkd3d-shader/ir.c
> +++ b/libs/vkd3d-shader/ir.c
> @@ -300,11 +300,7 @@ static bool shader_dst_param_normalise_outpointid(struct vkd3d_shader_dst_param
>
>      if (normaliser_is_in_control_point_phase(normaliser) && reg->type == VKD3DSPR_OUTPUT)
>      {
> -        if (reg->idx[2].offset != ~0u)
> -        {
> -            FIXME("Cannot insert phase id.\n");
> -            return false;
> -        }
> +        assert(reg->idx[2].offset == ~0u);
>          if (reg->idx[1].offset != ~0u)
>          {
>              WARN("Unexpected address at index 1.\n");

We could as well compare reg->idx_count against ARRAY_SIZE(reg->idx) here. We should also increase reg->idx_count here because we're adding an extra index.

This series will need to be adjusted for the signature changes in !197.