Re: [PATCH v3 0/3] MR1199: xmllite/writer : Implement a few APIs

[Nikolay Sivov (＠nsivov)]

Nikolay Sivov (@nsivov) commented about dlls/xmllite/writer.c:
> static HRESULT WINAPI xmlwriter_WriteSurrogateCharEntity(IXmlWriter *iface, WCHAR wchLow, WCHAR wchHigh)
>  {
> - xmlwriter *This = impl_from_IXmlWriter(iface);
> - xmlwriter *writer = impl_from_IXmlWriter(iface);
> - int codepoint;
> - WCHAR bufW[16];
> - FIXME("%p %d %d\n", This, wchLow, wchHigh);
> - TRACE("%p, %d, %d\n", writer, wchLow, wchHigh);
> - return E_NOTIMPL;
> - if (!IS_LOW_SURROGATE(wchLow))
> -
>    return WC_E_XMLCHARACTER;
> -
> - if (!IS_HIGH_SURROGATE(wchHigh))
> -
>    return WC_E_XMLCHARACTER;

There is a IS_SURROGATE_PAIR() to combine those two checks.