Re: [PATCH 0/1] MR2498: msado15: Implement _Recordset Find

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about dlls/msado15/filter.y:
> -
>
> +filter:
> - | filter line
>
> +;
> -
>
> +line: T_NEWLINE
> - | TOKEN_COLUMN oparations T_INT {
> -
> filter_add_integer_column(yyget_extra(scanner)->recordset, $1, $2, $3);
> - }
> - | TOKEN_COLUMN oparations T_FLOAT {
> -
> filter_add_float_column(yyget_extra(scanner)->recordset, $1, $2, $3);
> - }
> - | TOKEN_COLUMN oparations T_STRING
> - {
> -
> filter_add_string_column(yyget_extra(scanner)->recordset, $1, $2, $3);
> - }

The brace placement here is inconsistent.

The "parser_param" structure is passed as a parameter to yyparse, so you don't need to retrieve it from the scanner here. You can access it directly as "p", as specified in the %parse-param directive.