Re: [PATCH v7 0/8] MR436: vkd3d-shader/dxil: Implement the DXIL CAST instruction.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/dxil.c:
> -
>    FIXME("Unhandled non-scalar type class %u and/or %u.\n", from->class, to->class);
> -
>    vkd3d_shader_parser_error(&sm6->p, VKD3D_SHADER_ERROR_DXIL_INVALID_OPERAND,
> -
>            "Cast of non-scalar types is not implemented.");
> -
>    /* width is not available for non-scalar types so we can't attempt to compile it. */
> -
>    return VKD3DSIH_INVALID;
> - }
> - if (to->u.width == 8 || from->u.width == 8)
> - {
> -
>    FIXME("Unhandled 8-bit value.\n");
> -
>    vkd3d_shader_parser_error(&sm6->p, VKD3D_SHADER_ERROR_DXIL_INVALID_OPERAND,
> -
>            "Cast to/from an 8-bit type is not implemented.");
> -
>    return VKD3DSIH_INVALID;
> - }
> -
> - from_int = sm6_type_is_integer(from);
> - to_int = sm6_type_is_integer(to);

Maybe we should validate that if types are not integers, then they are floating point?