13 Oct
2023
13 Oct
'23
6:38 p.m.
As an unrelated note (that issue is the same before and after these patches), the fact we add a stack variable to the queue list looks not great: if a thread gets force terminated the queue will be left with bad data in the list. As unfortunate as it sounds, we probably have to allocate queue entry elsewise using some cache?
Anyone using TerminateThread() is asking for trouble. Unless we specifically run into an application that expects to be able to terminate a thread mid-wait, I don't think there's anything that needs to be done here.