On Thu Nov 3 19:36:26 2022 +0000, Zebediah Figura wrote:
The point is that merging the two changes makes it clear how SHBindToFolderIDListParent() differs from SHBindToParent(). I.e. in this case, the implementation is the same, except that you're using a custom shell folder instead of the desktop. Changing around the error handling muddies that, and if it's necessary then it should be its own patch.
I'm not sure what is meant by merging the two changes. Does it mean to merge the two commits, 'Implement SHBindToFolderIDListParent' and 'Reimplement SHBindToParent'? I did that with the last version and it didn't make it any clearer. What exactly should I do?
Well it does appear to be necessary to change the error handling of SHBindToParent since it doesn't conform to the behavior of Windows. But it is it's own patch as seen in the commits tab, "shell32/tests: Test SHBindToParent last parameter behavior." and "shell32: Reimplement SHBindToParent.".
I don't know what else to do.