[PATCH v3 1/2] comctl32/tests: Add test for listview sorting order.

[Jacob Czekalla]

From: Jacob Czekalla

---
 dlls/comctl32/tests/listview.c | 79 ++++++++++++++++++++++++++++++++++
 1 file changed, 79 insertions(+)

diff --git a/dlls/comctl32/tests/listview.c b/dlls/comctl32/tests/listview.c
index 1081a045cde..78751f3c720 100644
--- a/dlls/comctl32/tests/listview.c
+++ b/dlls/comctl32/tests/listview.c
@@ -23,6 +23,7 @@
 #include <stdio.h>
 #include <windows.h>
 #include <commctrl.h>
+#include <time.h>
 #include <objbase.h>

#include "wine/test.h"
@@ -3028,6 +3029,82 @@ static void test_subitem_rect(void)
     DestroyWindow(hwnd);
 }

+static INT WINAPI test_CallBackCompareEx(LPARAM first, LPARAM second, LPARAM lParam)
+{
+    HWND hwnd_List_view = (HWND)lParam;
+    CHAR buffer1[256], buffer2[256];
+    int itm1, itm2;
+
+    ListView_GetItemTextA(hwnd_List_view, first, 0, buffer1, sizeof(buffer1));
+    ListView_GetItemTextA(hwnd_List_view, second, 0, buffer2, sizeof(buffer2));
+
+    itm1 = atoi(buffer1);
+    itm2 = atoi(buffer2);
+
+    return (itm1 - itm2);
+}
+
+static void test_sort_order(void)
+{
+    LVITEMA lvi = {0};
+    LV_COLUMNA lvc = {0};
+    RECT rcClient;
+    CHAR buffer[256];
+    CHAR col_names[][2] = { "1", "2" };
+    HWND hwndListView = create_listview_control(LVS_REPORT);
+    int prev_value;
+
+    GetClientRect(hwndparent, &rcClient);
+
+    lvc.mask = LVCF_TEXT | LVCF_WIDTH | LVCF_SUBITEM;
+    lvc.pszText = col_names[0];
+    lvc.cx = rcClient.right / 2;
+    lvc.iSubItem = 0;
+    ListView_InsertColumnA(hwndListView, 0, &lvc);
+
+    lvc.pszText = col_names[1];
+    lvc.iSubItem = 1;
+    lvc.cx = rcClient.right / 2;
+    ListView_InsertColumnA(hwndListView, 1, &lvc);
+
+    srand((unsigned)time(NULL));
+
+    for (int i = 0; i < 100; i++)
+    {
+        lvi.mask = LVIF_TEXT;
+        lvi.iItem = i;
+        lvi.iSubItem = 0;
+        lvi.pszText = buffer;
+        sprintf(buffer, "%d", rand() % 100);
+        ListView_InsertItemA(hwndListView, &lvi);
+
+        sprintf(buffer, "%d", rand() % 100);
+        ListView_SetItemTextA(hwndListView, i, 1, buffer);
+    }
+
+    SendMessageA(hwndListView, LVM_SORTITEMSEX, (WPARAM) hwndListView, (LPARAM) test_CallBackCompareEx);
+
+    memset(&lvi, 0, sizeof(lvi));
+    for (int i = 1; i < 100; i++)
+    {
+        ListView_GetItemTextA(hwndListView, i-1, 0, buffer, sizeof(buffer));
+        prev_value = atoi(buffer);
+
+        ListView_GetItemTextA(hwndListView, i, 0, buffer,  sizeof(buffer));
+
+        if (atoi(buffer) < prev_value)
+        {
+            prev_value = 1;
+            break;
+        }
+        prev_value = 0;
+    }
+
+    todo_wine ok(!prev_value, "ListView not sorted correctly.\n");
+
+    DestroyWindow(hwndListView);
+}
+
 /* comparison callback for test_sorting */
 static INT WINAPI test_CallBackCompare(LPARAM first, LPARAM second, LPARAM lParam)
 {
@@ -3211,6 +3288,8 @@ static void test_sorting(void)
     ok(lstrcmpA(buff, names[3]) == 0, "Expected '%s', got '%s'\n", names[3], buff);

DestroyWindow(hwnd);
+
+    test_sort_order();
 }

static void test_ownerdata(void)