On Thu Sep 15 19:42:32 2022 +0000, Gabriel Ivăncescu wrote:
Well for several reasons:
- Since we aren't using Gecko events for them, there's no point in
doing that (just extra overhead). 2. I'm not even sure if Gecko supports creating some of them via CreateEvent (since it's deprecated). 3. The rest of the code (i.e. create_message_event, create_storage_event) create a normal "Event" from Gecko for nsevent, so this keeps it symmetrical. That's because their event type is "Event" since we don't use Gecko's. To be honest I don't see any benefit in creating the actual Gecko nsevent here for them.
1. I'm not sure what you mean, if you suggest not creating the event at all, that's now what the patch is doing. 2. I'd suggest to know it before using it as an argument. 3. Is there anything depending on it? The alternative would be to change other callers to make Gecko match MSHTML.