3 Apr
2023
3 Apr
'23
7:08 p.m.
On Mon Apr 3 08:33:18 2023 +0000, Ziqing Hui wrote:
changed this line in [version 2 of the diff](/wine/wine/-/merge_requests/2546/diffs?diff_id=40282&start_sha=5a3dd701d483b5849504a3a5c343f17091ec8a7c#d19138de09a66cf3bcf4e698b2f5c81e9daf14a2_869_792)
For the demuxer pad-removed I believe we at least need to unlink the compressed pad (the one that's being removed) from the downstream decodebin. We don't need to release the decodebin because the larger bin has ownership, though.
In that case I don't think that the stream pad-removed actually needs to do anything, if unlinking the final source pad is handled by the demuxer pad-removed. It's maybe a bit awkward that we lose symmetry that way, but still probably better.