Re: [PATCH 0/6] MR444: vkd3d-shader/ir: Check that blocks are correctly nested.

[Henri Verbeet (＠hverbeet)]

> @@ -1489,6 +1489,7 @@ static void VKD3D_PRINTF_FUNC(3, 4) validator_error(struct validation_context *c
>      va_end(args);
>
>      vkd3d_shader_parser_error(ctx->parser, error, "instruction %zu: %s", ctx->instruction_idx + 1, buf.buffer);
> +    FIXME("VSIR validation error: instruction %zu: %s\n", ctx->instruction_idx + 1, buf.buffer);
>
>      vkd3d_string_buffer_cleanup(&buf);
>  }

ERR seems appropriate. There's perhaps also an argument to be made for dumping the messages buffer to ERR on failure in vsir_validate() instead of duplicating the message here; I don't feel strongly about it though.
> Hull shaders have a different temps count for each phase, and the
> parser only reports the count for the patch constant phase.
> In order to properly check for temps count on hull shaders, we first
> need to decode its phases.

Right, though in principle DCL_TEMPS should at least never have a count greater than "shader_desc.temp_count" either.
> @@ -209,6 +209,7 @@ enum vkd3d_shader_error
>      VKD3D_SHADER_ERROR_VSIR_DUPLICATE_DCL_TEMPS         = 9013,
>      VKD3D_SHADER_ERROR_VSIR_INVALID_DCL_TEMPS           = 9014,
>      VKD3D_SHADER_ERROR_VSIR_INVALID_INDEX               = 9015,
> +    VKD3D_SHADER_ERROR_VSIR_INVALID_INSTRUCTION_NESTING  = 9016,

Stray space.