On Mon Nov 11 13:53:54 2024 +0000, Matteo Bruni wrote:
Sorry it took me a while to finish the review. I've got a bunch of comments but nothing really important. In addition, as a pet peeve of mine, I find a bit surprising when a patch is titled "Refactor" but then it fixes tests (something you wouldn't expect from a simple refactor). I'd rather say "Improve" or something like that.
Not a problem. :)
I see what you mean with "refactor", I've changed a commit message to use "improve" and changed the title of this MR as well.