Re: [PATCH 0/1] MR6192: jscript: Implement arguments.caller.

[Jacek Caban (＠jacek)]

Jacek Caban (@jacek) commented about dlls/jscript/function.c:
> +};
> -
>
> static const builtin_info_t Arguments_info = {
> - .class       = JSCLASS_ARGUMENTS,
> - .call        = Arguments_value,
> - .props_cnt   = ARRAY_SIZE(Arguments_props),
> - .props       = Arguments_props,
> - .destructor  = Arguments_destructor,
> - .lookup_prop = Arguments_lookup_prop,
> - .next_prop   = Arguments_next_prop,
> - .prop_get    = Arguments_prop_get,
> - .prop_put    = Arguments_prop_put,
> - .gc_traverse = Arguments_gc_traverse
>
> +};
> -
>
> +static const builtin_info_t Arguments_ES5_info = {

Duplicating the descriptor like that just for one property is not great. Do you know if there are more cases like this? Maybe we should extend property descriptor to specify the maximal version? Given that it will be probably used only for ES3, maybe something like `PROPF_ES3` (with a meaning of max version rather than min)? Or maybe even move that out of flags?