Re: [PATCH 8/8] vkd3d-shader/hlsl: Add offset parameter to 'Load' method.

[Zebediah Figura (she/her)]

On 8/19/22 19:28, Francisco Casas wrote:
> diff --git a/libs/vkd3d-shader/hlsl.y b/libs/vkd3d-shader/hlsl.y
> index ca3506e3..4d74d3ae 100644
> --- a/libs/vkd3d-shader/hlsl.y
> +++ b/libs/vkd3d-shader/hlsl.y
> @@ -2402,26 +2402,39 @@ static bool add_method_call(struct hlsl_ctx *ctx, struct list *instrs, struct hl
>               && object_type->sampler_dim != HLSL_SAMPLER_DIM_CUBEARRAY)
>       {
>           const unsigned int sampler_dim = hlsl_sampler_dim_count(object_type->sampler_dim);
> -
>    const unsigned int offset_dim = hlsl_offset_dim_count(object_type->sampler_dim);
>     struct hlsl_ir_resource_load *load;
> -
>    struct hlsl_ir_node *offset = NULL;
>     struct hlsl_ir_node *coords;
> -
>    bool multisampled;
> -
> -

Double newline here.
> -
>    multisampled = object_type->sampler_dim == HLSL_SAMPLER_DIM_2DMS
> -
>            || object_type->sampler_dim == HLSL_SAMPLER_DIM_2DMSARRAY;
>
> -
>    if (object_type->sampler_dim == HLSL_SAMPLER_DIM_2DMS
> -
>            || object_type->sampler_dim == HLSL_SAMPLER_DIM_2DMSARRAY)
> -
>    if (params->args_count < 1 + multisampled || params->args_count > 3 + multisampled)
>     {
> -
>        FIXME("'Load' method for multi-sample textures.\n");
> -
>        hlsl_error(ctx, loc, VKD3D_SHADER_ERROR_HLSL_WRONG_PARAMETER_COUNT,
> -
>                "Wrong number of arguments to method 'Load': expected betweed %u and %u, but got %u.",

Typo, "betweed".