18 Nov
2025
18 Nov
'25
10:32 a.m.
On Thu Nov 13 11:07:20 2025 +0000, Sven Baars wrote:
Why don't we just return an `HRESULT` here and return that from `ItemMenu_InvokeCommand`, instead of the verbose ERRs?
Returning `E_FAIL` everywhere and leaving the `ERR`s is not useful. Many of the failure paths seem like things Windows apps may naturally run into, so we shouldn't be spamming `ERR`s in that case. We can be more specific with the return values (tests would be useful) and most of the `ERR`s can be removed, or at least replaced with warns or traces.