Re: [PATCH v5 0/3] MR1343: windows.media: Add WinRT Closed Captioning interface.

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/windows.media/captions.c:
> -
>
> +static HRESULT WINAPI captions_get_FontColor( IClosedCaptionPropertiesStatics *iface, ClosedCaptionColor *value )
> +{
> - FIXME( "(iface %p, color %p) - stub.\n", iface, value );
> -
> - if (!value)
> -
>    return E_POINTER;
> -
> - return E_NOTIMPL;
>
> +}
> -
>
> +static HRESULT WINAPI captions_get_ComputedFontColor( IClosedCaptionPropertiesStatics *iface, Color *value )
> +{
> - FIXME( "(iface %p, computed color %p) - stub.\n", iface, value );
> -
> - if (!value)

I think you should add tests to show that this check is actually supposed to be done, and this error value supposed to be returned, or just don't do the check at all. Especially since it's just a stub right now and since you never access the pointer. This is true for all the similar checks below.