21 Nov
2023
21 Nov
'23
11:47 p.m.
On Tue Nov 21 20:49:03 2023 +0000, Alexandre Julliard wrote:
Yes, but are the previous rules necessary? Why isn't switching the CFA sufficient?
You're right, we should drop the sp rules and it'll use the default rule everywhere.
This made me look at it a bit closer and I spotted a couple of places where I made some mistakes: Some user frame CFI left overs, and an invalid user CFI offset, and another set of issues where the kernel CFI is briefly invalid in the return path, whenever the register used as a CFA base is restored early before switching back to the user stack.
I've made some changes, also tried to apply them to the ARM code, and pushed them to https://gitlab.winehq.org/wine/wine/-/merge_requests/1088.