Re: [PATCH v3 0/2] MR1321: Reject wic invalid formats

[Nikolay Sivov (＠nsivov)]

Nikolay Sivov (@nsivov) commented about dlls/d2d1/tests/d2d1.c:
> -
>                    || wic_formats[i] == &GUID_WICPixelFormat128bppPRGBAFloat
> -
>                    || wic_formats[i] == &GUID_WICPixelFormat128bppRGBFloat
> -
>                    || wic_formats[i] == &GUID_WICPixelFormat64bppPRGBAHalf
> -
>                    || wic_formats[i] == &GUID_WICPixelFormat64bppRGBHalf
> -
>                    || ((wic_formats[i] == &GUID_WICPixelFormat32bppRGBA1010102)
> -
>                    && !((j == DXGI_FORMAT_UNKNOWN || j == DXGI_FORMAT_R10G10B10A2_UNORM)
> -
>                    && (k == D2D1_ALPHA_MODE_UNKNOWN || k == D2D1_ALPHA_MODE_PREMULTIPLIED)))
> -
>                    || ((wic_formats[i] == &GUID_WICPixelFormat8bppY)
> -
>                    && !((j == DXGI_FORMAT_UNKNOWN || j == DXGI_FORMAT_R8_UNORM)
> -
>                    && (k == D2D1_ALPHA_MODE_UNKNOWN || k == D2D1_ALPHA_MODE_IGNORE)))
> -
>                    || ((wic_formats[i] == &GUID_WICPixelFormat16bppCbCr)
> -
>                    && !((j == DXGI_FORMAT_UNKNOWN || j == DXGI_FORMAT_R8G8_UNORM)
> -
>                    && (k == D2D1_ALPHA_MODE_UNKNOWN || k == D2D1_ALPHA_MODE_IGNORE))))
> -
>                ok(hr == E_INVALIDARG || broken(hr == D2DERR_UNSUPPORTED_PIXEL_FORMAT
> -
>                        && wic_formats[i] == &GUID_WICPixelFormat32bppRGBA1010102), "Got unexpected hr %#lx.\n", hr);
> -
>            else

To me this looks very hard to follow. I think it's fine to leave only working WIC formats in tests, not every single one.