17 Sep
2024
17 Sep
'24
6:42 p.m.
On Tue Sep 17 17:42:52 2024 +0000, Sergei Chernyadyev wrote:
it could work out in the first case, but not here, as if icon is already present, this condition will always be true
Well, even in the first case I'm not sure to understand what it is supposed to do. There's already a check at the top of the function to make sure we can read the struct from the data.
Then there's separate checks to make sure we have enough data for the icon bitmaps, I don't think these are useful.