Re: [PATCH 0/1] MR1246: vbscript: Implement PRNG functions.

[Jacek Caban (＠jacek)]

Jacek Caban (@jacek) commented about dlls/vbscript/global.c:
> - {
> -
>    hres = to_double(arg, &dtoi.d);
> -
>    if (FAILED(hres))
> -
>        return hres;
> - }
> - else
> - {
> -
>    dtoi.d = GetTickCount() * 0.001;
> - }
> -
> - seed = dtoi.i[1];
> - seed ^= (seed >> 16);
> - seed = ((seed & 0xffff) << 8) | (This->ctx->script_obj->rnd & 0xff);
> - This->ctx->script_obj->rnd = seed;
> -
> - return S_OK;

This may leave res uninitialized. It should probably be set to VT_EMPTY, a test for returned value would be nice.