26 Oct
2022
26 Oct
'22
3:48 p.m.
On Tue Oct 25 18:11:19 2022 +0000, Zebediah Figura wrote:
I don't think this is a sufficient explanation. What reordering does this prevent? What memory barrier is this paired with? (Itself?)
Quoting my previous reply:
The idea was that `server_select` should act as a strong memory barrier itself, so that the thread calling `FlushProcessWriteBuffers` did not need to call `MemoryBarrier()` explicitly.
That said, I think it makes sense to just put `MemoryBarrier()` in `NtFlushProcessWriteBuffers`.