Re: [PATCH v2 0/4] MR44: vkd3d-shader/dxil: Read and validate DXIL bitcode blocks.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/dxil.c:
> +#define VKD3D_SM6_VERSION_MAJOR(version) (((version) >> 4) & 0xf)
> +#define VKD3D_SM6_VERSION_MINOR(version) (((version) >> 0) & 0xf)
> -
>
> +#define BITCODE_MAGIC VKD3D_MAKE_TAG('B', 'C', 0xc0, 0xde)
> -
>
> +enum dxil_bc_block_id
> +{
> - BLOCKINFO_BLOCK       =  0,
> - MODULE_BLOCK          =  8,
> - PARAMATTR_BLOCK       =  9,
> - PARAMATTR_GROUP_BLOCK = 10,
> - CONSTANTS_BLOCK       = 11,
> - FUNCTION_BLOCK        = 12,
> - VALUE_SYMTAB_BLOCK    = 14,
> - METADATA_BLOCK        = 15,
> - METADATA_ATTACHMENT_BLOCK = 16,

I don't know why, but on https://www.llvm.org/docs/BitCodeFormat.html#metadata-attachment it seems that the name is just `METADATA_ATTACHMENT`, without `_BLOCK`.