Re: [PATCH v6 0/1] MR7052: vbscript: implement Join()

[Jacek Caban (＠jacek)]

Jacek Caban (@jacek) commented about dlls/vbscript/global.c:
> -
>        return MAKE_VBSERROR(VBSE_OLE_NO_PROP_OR_METHOD);
> -
>    case VT_VARIANT|VT_ARRAY:
> -
>        sa = V_ARRAY(args);
> -
>        break;
> -
>    case VT_VARIANT|VT_ARRAY|VT_BYREF:
> -
>        sa = *V_ARRAYREF(args);
> -
>        break;
> -
>    default:
> -
>        return MAKE_VBSERROR(VBSE_TYPE_MISMATCH);
> - }
> -
> - if (args_cnt == 2) {
> -
>    if (V_VT(args + 1) == VT_NULL)
> -
>        return MAKE_VBSERROR(VBSE_ILLEGAL_NULL_USE);
> -
>    if (V_VT(args + 1) != VT_BSTR) {
> -
>        hres = to_string(args + 1, &delimiter);

This also allocates `delimiter`, so we should free it on cleanup.