Re: [PATCH v2 0/1] MR6075: Add chevron visibility test to check the case of restoring band width to ideal value

[Zhiyi Zhang (＠zhiyi)]

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/rebar.c:
> - rbi.cyMinChild = rbi.cxMinChild;
> - rbi.hwndChild = build_toolbar(1, hRebar);
> - rbi.fStyle = RBBS_USECHEVRON | RBBS_NOGRIPPER;
> - SendMessageA(hRebar, RB_INSERTBANDA, 0, (LPARAM)&rbi);
> - SendMessageA(hRebar, RB_INSERTBANDA, 1, (LPARAM)&rbi);
> -
> - SetRectEmpty(&g_chevron_rect);
> - SendMessageA(hRebar, RB_PUSHCHEVRON, 0, 0);
> - ok(!IsRectEmpty(&g_chevron_rect), "Unexpected empty chevron rect\n");
> -
> - // increase band width to make it more then ideal value to hide chevron
> - rbi.fMask = RBBIM_SIZE;
> - rbi.cx = rbi.cxIdeal << 1;
> - SendMessageA(hRebar, RB_SETBANDINFOA, 0, (LPARAM)&rbi);
> -
> - SetRectEmpty(&g_chevron_rect);

I don't think you should set g_chevron_rect empty. You should do the opposite because you're checking for an empty rectangle from the RB_PUSHCHEVRON message.