On Fri Nov 18 08:12:32 2022 +0000, Mohamad Al-Jaf wrote:
@epo: Could you explain why it's wrong? I used past commits as a reference and the stubs that were added had SetLastError(ERROR_CALL_NOT_IMPLEMENTED). Yeah I agree, I don't think apps actually check for it. Sure, that's fine. Yeah, that makes sense given what the function is used for. Thanks for the link, closing this merge request.
setting last error is only meaningful when you can tell when the function failed
(returning a BOOL: FALSE is an error, returning NTSTATUS: anything but STATUS_SUCCESS is an error, ... in this very function, there's no documented way to return an error...)
0 means there's no inline context at this address... but it doesn't tell if the address is actually mapped, if there's a loaded module at this address, if there's a function at this address...