Nikolay Sivov (@nsivov) commented about dlls/vbscript/interp.c:
/* FIXME: We should check if we're not modifying an existing static array here */
- VariantClear(ref.u.v);
- V_VT(ref.u.v) = VT_ARRAY|VT_VARIANT;
- V_ARRAY(ref.u.v) = array;
- VARIANT *v = ref.u.v;
Please move declaration before statements. We have warnings enabled for that, for me it gives:
``` ../../wine-git/dlls/vbscript/interp.c: In function ‘interp_redim’: ../../wine-git/dlls/vbscript/interp.c:1315:5: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] 1315 | VARIANT *v = ref.u.v; | ^~~~~~~ ```
Same applies to interp_redim_preserve().