Huw Davies (@huw) commented about dlls/winepulse.drv/pulse.c:
goto fail; /* Wait for connection */
- while (pulse_cond_wait()) {
pa_context_state_t state = pa_context_get_state(pulse_ctx);
if (state == PA_CONTEXT_FAILED || state == PA_CONTEXT_TERMINATED)
goto fail;
- while ((state = pa_context_get_state(pulse_ctx) != PA_CONTEXT_READY) &&
```suggestion:-0+0 while ((state = pa_context_get_state(pulse_ctx)) != PA_CONTEXT_READY && ``` (I made this mistake in my original comment, but editted it soon afterwards).
Also, the commit message now needs updating. Something like:
winepulse: Use the predicate to terminate the connect cond_wait loop.