On Fri Oct 21 18:17:46 2022 +0000, Jacek Caban wrote:
It looks better, thanks, but I think we should forward even more IHTMLDocument* calls to document node instead of other way around, there are very few exceptions (if any). It should be fine to forward stubs as well.
For stubs, I generally avoided those that don't have some respective gecko interface, because I was a bit unsure how their implementation would actually look like.
Some of the others aren't forwarded because they used some fields from the former `basedoc`, which are different on HTMLDocumentObj compared to node (most commonly "window"), and I didn't want to change the existing behavior at all, but keep it no-op.
As for the "other way around", seems it's just get_referrer; since this is likely tied to the window, I wanted to avoid forwarding it to the node (same reason as above). As I understand, the doc object is always available, but the node might not always be. It should be fine this way?
Which stubs did you have in mind to forward, only the IHTMLDocument* ones, or also for the other interfaces?