Re: [PATCH v3 0/6] MR491: vkd3d-shader/dxil: Handle control flow instructions.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/vkd3d_shader_private.h:
>      uint64_t immconst_uint64[VKD3D_DVEC2_SIZE];
>      double immconst_double[VKD3D_DVEC2_SIZE];
>      unsigned fp_body_idx;
> -
>    /* for phi incomings: a dominant block id. */

I guess the correct word here is "precedessor" rather than "dominant", right? A predecessor block is not necessarily dominating the current one, nor is a dominating node necessarily a predecessor.

Also, this field is in a union with the immediate constant values, but as far as I can tell a PHI incoming parameter can be a constant. So wouldn't they be fighting for the union?