Re: [PATCH v6 0/4] MR261: vkd3d-shader: Add compiler option to specify matrix majority.

[Nikolay Sivov (＠nsivov)]

On Thu Jul 20 15:11:36 2023 +0000, Henri Verbeet wrote:
> > diff --git a/tests/shader_runner_vulkan.c b/tests/shader_runner_vulkan.c
> > index ce9ac7e8..716b922c 100644
> > --- a/tests/shader_runner_vulkan.c
> > +++ b/tests/shader_runner_vulkan.c
> > @@ -26,6 +26,7 @@
> >  #include "vulkan/vulkan.h"
> >  #include "vkd3d_shader.h"
> >  #include "vkd3d.h"
> > +#include "vkd3d_d3dcompiler.h"
> >  #include "shader_runner.h"
> >  #include "vkd3d_test.h"
>
> That seems a bit unfortunate. I wouldn't want to delay the series over
> it, but architecturally it might be nicer to use something specific to
> the shader runner, instead of reusing the d3dcompiler flags.

Is that because it's a vulkan one, or it's better to avoid in all runners? We have this header used by d3d9 and d3d11 runners already, so I didn't think much of it.