Re: [PATCH 0/1] MR9486: windowscodecs: correct GIF LZW compression initialization

[Dmitry Timoshkov (＠dmitry)]

Dmitry Timoshkov (@dmitry) commented about dlls/windowscodecs/gifformat.c:
>                      /* Image Data */
> -
>                    hr = gif_compress(This->encoder->stream, This->image_data, This->width * This->height);
> -
>                    hr = gif_compress(This->encoder->stream, This->image_data, This->width * This->height, color_bits);
>                    if (hr == S_OK)
>                        This->committed = TRUE;
>                }
>            }
> -
>            else if (hr == S_OK)
> -
>            {
> -
>                int color_bits = 1;
> -
>                while ((1 << color_bits) < This->encoder->colors) color_bits++;
> -
> -
>                hr = gif_compress(This->encoder->stream, This->image_data, This->width * This->height, color_bits);
> -
>                if (hr == S_OK)
> -
>                    This->committed = TRUE;
> -
>            }

It should be possible to avoid the code duplication, for instance by writing palette only when necessary.