Nikolay Sivov (@nsivov) commented about dlls/mfmediaengine/main.c:
- if (src_mf_rect)
- {
src_rect.left = src_mf_rect->left * frame_width + 0.5f;
src_rect.top = src_mf_rect->top * frame_height + 0.5f;
src_rect.right = src_mf_rect->right * frame_width + 0.5f;
src_rect.bottom = src_mf_rect->bottom * frame_height + 0.5f;
- }
- else
- {
src_rect.right = frame_width;
src_rect.bottom = frame_height;
- }
- if (FAILED(hr = IWICBitmap_GetPixelFormat(bitmap, &format))
|| FAILED(IWICBitmap_GetSize(bitmap, &dst_width, &dst_height)))
return hr;
Those shouldn't really fail, unless you see this error handling with user-defined IWICBitmap. If we are going to keep failure checks, we probably should use GetSize() result too?