Re: [PATCH 0/1] MR1444: kernel32: Unstub MoveFileTransactedW, Use MoveFileWithProgressW

[Etaash Mathamsetty (＠etaash.mathamsetty)]

Etaash Mathamsetty (@etaash.mathamsetty) commented about dlls/kernel32/path.c:
> */
>  BOOL WINAPI MoveFileTransactedA(const char *source, const char *dest, LPPROGRESS_ROUTINE progress, void *data, DWORD flags, HANDLE handle)
>  {
> - FIXME("(%s, %s, %p, %p, %ld, %p)\n", debugstr_a(source), debugstr_a(dest), progress, data, flags, handle);
> - SetLastError(ERROR_CALL_NOT_IMPLEMENTED);
> - return FALSE;
> - BOOL ret;
> -
> - TRACE("(%s, %s, %p, %p, %ld, %p)\n", debugstr_a(source), debugstr_a(dest), progress, data, flags, handle);
> -
> - ret = MoveFileWithProgressA(source, dest, progress, data, flags);
> - FIXME("Transaction handle not finalized.");

instead of saving the return value to a temp variable and returning the temp variable, I think you could moving the FIXME before the call and just return MoveFileWithProgressA, thus removing the need of the variable