On Thu Apr 25 13:46:16 2024 +0000, Jinoh Kang wrote:
(question) I don't really care about this a bit, but my anecdotal experience of getting reviewed tells us that we want to either make this consistent with `mark_block_uninitialized`...
VALGRIND_DISCARD( VALGRIND_MAKE_MEM_NOACCESS( ptr, size ));...or the other way around. Is this something you've missed, or am I overly cautious? (Wine codebase, for some reason, likes unbalanced parenthesis spacing as in `foo( bar( baz ))`, although I've seen both balanced `foo( bar( baz ) )` and unbalanced parenthesis spacing get committed recently in server/, so I'm not even sure what's going on. Feel free to use your own judgment.)
I prefer balanced paren spacing (one reason is because clang-format can do it, another is symmetry and consistency), but both schemes happen to be used.