On Thu Jul 11 12:46:25 2024 +0000, Elizabeth Figura wrote:
Scene resetting probably should apply to d3d8 and ddraw as well; would you mind testing that and then moving the wined3d_device_end_scene() call to wined3d_device_reset() if so?
Sure! Writing tests for that in d3d8 seems relatively easy, but ddraw is proving a bit more difficult. There doesn't seem to be an explicit `Reset` method for D3D7 and below, the closest I can find is in `dlls/ddraw/tests/ddraw4.c:test_d3d_state_reset(void)`. I'm trying to mix in the `BeginScene()` and `EndScene()` calls there and not having much luck.
Either way, if we're adding tests for those, it's probably worth splitting off from this MR. Would that make sense to you as well? Just having the `UpdateSurface()` with multisampled surfaces in this MR, and then opening up a separate MR for the scene state on device reset patches?