Connor McAdams (@cmcadams) commented about dlls/comctl32/tests/syslink.c:
- hr = IAccessible_get_accName(acc, varChild, &name);
- ok(hr == S_OK, "accName failed, hr=%lx\n", hr);
- if (SUCCEEDED(hr)) {
ok(!!name && !wcscmp(name, L"Head Name1 Middle Name2 Tail"),
"unexpected name %s\n", debugstr_w(name));
SysFreeString(name);
- }
- hr = IAccessible_get_accDefaultAction(acc, varChild, &name);
- ok(hr == S_FALSE, "accDefaultAction failed, hr=%lx\n", hr);
- if (SUCCEEDED(hr))
ok(!name, "unexpected default action %s\n", debugstr_w(name));
- hr = IAccessible_accLocation(acc, &left, &top, &width, &height, varChild);
- ok(hr == S_OK, "accLocation failed, hr=%lx\n", hr);
Not a big deal, but is there any reason you aren't checking the values returned here? Just want to make sure it's intentional and not an oversight. Same goes for the other `accLocation` calls with child IDs.