Re: [PATCH v2 0/5] MR207: vkd3d-shader/hlsl: Support non-constant offset dereferences, part 1

[Zebediah Figura (＠zfigura)]

On Wed May 24 15:08:36 2023 +0000, Francisco Casas wrote:
> That would save some code, but it seemed odd to me to make the space
> between 
> `hlsl_transform_ir(ctx, lower_nonconstant_vector_derefs, body, NULL);`
> and
> `hlsl_transform_ir(ctx, lower_int_dot, body, NULL);`
> the only place in the whole codebase where HLSL_OP2_DOT for bools can exist.
> I will change it if nobody disagrees though.

We don't have tests for this, but dot() of bools is uniquely supposed to return float.

I don't necessarily object to having HLSL_OP2_DOT mean something other than dot(), although I don't know that it's great. The idea that dot() of bools returns a bool is weird, too. I don't hate either one but I'm not sure it's better than the existing code either.