Nikolay Sivov (@nsivov) commented about dlls/propsys/tests/propsys.c:
- VARTYPE type;
- WCHAR *name;
- hr = IPropertyDescription_GetPropertyKey(desc, &key);
- ok_(__FILE__, line)(SUCCEEDED(hr), "got %#lx\n", hr);
- ok_(__FILE__, line)(IsEqualPropertyKey(key, *expect_key), "%s != %s\n", debugstr_propkey(&key),
debugstr_propkey(expect_key));
- hr = IPropertyDescription_GetCanonicalName(desc, &name);
- ok_(__FILE__, line)(SUCCEEDED(hr), "got %#lx\n", hr);
- if (SUCCEEDED(hr))
- {
ok_(__FILE__, line)(!wcscmp(name, expect_name), "%s != %s\n", debugstr_w(name), debugstr_w(expect_name));
CoTaskMemFree(name);
- }
- hr = IPropertyDescription_GetPropertyType(desc, &type);
- ok_(__FILE__, line)(SUCCEEDED(hr), "got %#lx\n", hr);
Here and in other places I think it's better to explicitly check for S_OK.