Re: [PATCH 0/3] MR7538: winegstreamer: Implement type handler functions for media sink.

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/winegstreamer/media_sink.c:
> static HRESULT WINAPI stream_sink_type_handler_GetMajorType(IMFMediaTypeHandler *iface, GUID *type)
>  {
> - FIXME("iface %p, type %p.\n", iface, type);
> - struct stream_sink *stream_sink = impl_from_IMFMediaTypeHandler(iface);
> - return E_NOTIMPL;
> - TRACE("iface %p, type %p.\n", iface, type);
> -
> - if (!type)
> -
>    return E_POINTER;
> -
> - return IMFMediaType_GetMajorType(stream_sink->type, type);

If I'm reading the code correctly `stream_sink->type` may be NULL. There's a test for that case, and it looks like `IMFMediaSink_AddStreamSink` may also return `E_INVALIDARG` in that case. It's flagged as broken, but maybe we could decide to do that instead so that we can then assume media type is always set?