Re: [PATCH v2 0/5] MR153: hlsl: Return hlsl_ir_node pointers from instruction constructors, part 1.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/hlsl.c:
> -struct hlsl_ir_if *hlsl_new_if(struct hlsl_ctx *ctx, struct hlsl_ir_node *condition, struct vkd3d_shader_location loc)
> +struct hlsl_ir_if *hlsl_new_if(struct hlsl_ctx *ctx, struct hlsl_ir_node *condition,
> -
>    struct hlsl_block *then_block, struct hlsl_block *else_block, const struct vkd3d_shader_location *loc)
>
> {
>      struct hlsl_ir_if *iff;
>  if (!(iff = hlsl_alloc(ctx, sizeof(*iff))))
>      return NULL;
> - init_node(&iff->node, HLSL_IR_IF, NULL, &loc);
> - init_node(&iff->node, HLSL_IR_IF, NULL, loc);
> hlsl_src_from_node(&iff->condition, condition);
> - hlsl_block_init(&iff->then_instrs);
> - hlsl_block_init(&iff->else_instrs);
> - hlsl_block_init(&iff->then_block);
> - list_move_tail(&iff->then_block.instrs, &then_block->instrs);

Why not `hlsl_block_add_block()`?