Re: [PATCH v5 0/2] MR4774: msvcrt: Compare environmental variable names case insensitively

[Piotr Caban (＠piotr)]

Piotr Caban (@piotr) commented about dlls/msvcrt/tests/environ.c:
> - const char *uppercase_env = getenv("APPDATA");
> - const char *lowercase_env = getenv("appdata");
> - const wchar_t *uppercase_wenv = _wgetenv(L"APPDATA");
> - const wchar_t *lowercase_wenv = _wgetenv(L"appdata");
> -
> - ok( uppercase_env == lowercase_env, "getenv() must be case insensitive, %p should be %p\n",
> -
>    lowercase_env, uppercase_env );
> - ok( uppercase_wenv == lowercase_wenv, "_wgetenv() must be case insensitive, %p should be %p\n",
> -
>    lowercase_wenv, uppercase_wenv );
> -
> - ok( !_putenv("cAt=bar"), "Failed to set CAT=bar\n" );
> - ok( !_putenv("CAT=BAR"), "Failed to set CAT=BAR\n" );
> - ok( !strcmp(getenv("cAt"), "BAR"), "_putenv() must be case insensitive\n" );
> -
> - ok( !_wputenv(L"cAt=bar"), "Failed to set CAT=bar\n" );
> - ok( !p_wputenv_s(L"CAT", L"BAR"), "Failed to set CAT=BAR\n" );

Other tests that use `p_wputenv_s` are checking if the function is available. Please use `_wputenv` instead or ski[p the test if `p_wputenv_s == NULL`.