On Thu Jan 23 22:13:18 2025 +0000, William Horvath wrote:
I understand what you're saying and think you're correct, but I think there has to be a lazier way to do this correctly, instead of requiring a tedious tree-wide update for the benefit of almost nobody. This already isn't enough to result in a working `wine-preloader` if lld is used instead of bfd (it needs `-Wl,--no-relax` as well), so I'm just going to drop this for now. Thanks for your thoughts and insight into the topic.
I don't understand what's so difficult about also adding it to `abort_thread` that you had to close this?
I never said you should make it tree-wide in a single MR, or even in other MRs if you don't feel like it. Any improvement, even partial, is still fine.
But since you already touch this component, why not just add it to `abort_thread` as well?
Anyway, the other thing is it still should be encapsulated in a macro, IMO. Still waiting for Alexandre's suggestion(s) on that one.
The scope of this MR is fine as-is.