Re: [PATCH 0/3] MR5221: dmime: MIDI seqtrack

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/dmime/midi.c:
>  return hr;
>
> }
>
> +static HRESULT midi_parser_handle_note_on_off(struct midi_parser *parser, struct midi_event *event)
> +{
> - BYTE new_velocity = (event->status & 0xf0) == 0x80 ? 0 : event->data[1]; /* DirectMusic doesn't have noteoff velocity */
> - BYTE note = event->data[0], channel = event->status & 0xf;
> - DWORD index = (DWORD)channel * 128 + note;
> - MUSIC_TIME dmusic_time;
> - struct midi_seqtrack_item *note_state = parser->note_states[index];
> - DMUS_IO_SEQ_ITEM *seq_item;
> - struct midi_seqtrack_item *item;
> - /* Testing shows there are 2 cases to deal with here:

I know I said that I liked avoiding vertical space waste but please use blank lines from time to time between logical blocks to let the code breathe a bit.

Unless in very short functions, we usually have a blank line after declarations for instance. Before return statements too, etc... There's no hard or well defined rule but it would make the code more readable.