Re: [PATCH 0/5] MR1560: d3d10/effect: Preshader instructions support improvements.

[Matteo Bruni (＠Mystral)]

Matteo Bruni (@Mystral) commented about dlls/d3d10/effect.c:
>  }
>
> }
>
> +static void pres_min(float **args, unsigned int n, const struct preshader_instr *instr)
> +{
> - float *retval = args[2];
> - unsigned int i;
> -
> - for (i = 0; i < instr->comp_count; ++i)
> -
>    retval[i] = min(args[0][i], args[1][i]);

Have you checked that the "scalar" modifier is not supported by min/max opcodes?

I tried to have a quick look but I only managed to confuse myself :D I think it's not supported but I'd like for you to double check, if you haven't already.

Either way, it would be nice to have a test for that kind of case, like "min(g_var.x, g_var2)".