22 Mar
2023
22 Mar
'23
4:54 p.m.
A couple observations/questions from a partial review:
The first patch looks like a proper bug fix, maybe we want it in independently of the rest of this MR?
Regarding your question in the second patch, the answer to seems to be yes, `wined3d_rendertarget_view_vk_get_image_view` calls `wined3d_texture_vk_get_default_image_info`.
In patch 5 (and others), could we extend `wined3d_texture_vk_barrier` to handle barriers before the blits, and not worry about barriers after? Getting rid of the special case with mips/layers? (I'm not exactly sure how to nicely handle this, but currently it looks a little unwieldy. Besides, maybe we could more easily cut more `wined3d_context_vk_image_barrier` sandwitches with a generalized version.)